[FFmpeg-cvslog] r8912 - trunk/doc/ffmpeg-doc.texi
Diego Biurrun
diego
Sun May 6 14:06:55 CEST 2007
On Sun, May 06, 2007 at 01:41:42PM +0200, Michael Niedermayer wrote:
>
> On Sun, May 06, 2007 at 12:48:41PM +0200, diego wrote:
> >
> > Log:
> > Add a note about maintaining alphabetical order to patch submission checklist.
>
> [...]
> > @item
> > + Longer lists of things are usually kept in alphabetical order.
>
> this is irrelevant and if true, just so by chance
> just because some list is long does not mean it should be in aphabetical order
> similarely just because a list is short does not mean it should not be in
> alphabetical order
>
> > If you
> > + add an item, make sure to maintain alphabetical order.
>
> a long enum or large struct doesnt have its members in alphabetical order
> normally and even if it does its not possible to maintain this with public
> stuff
>
> so while i agree with the spirit of the change i dont agree at all with the
> used wording
>
> it rather should be something like
>
> you should maintain alphabetical order in alphabetically ordered lists as
> long as doing so does not break API/ABI compatibility
Perfect, commit it. :)
Diego
More information about the ffmpeg-cvslog
mailing list