[Ffmpeg-cvslog] r8424 - trunk/libavformat/utils.c

[Michael Niedermayer]

Hi

On Tue, Mar 20, 2007 at 11:06:34AM +0100, Baptiste Coudurier wrote:
> Baptiste Coudurier wrote:
> > Hi
> > 
> > michael wrote:
> >> Author: michael
> >> Date: Fri Mar 16 23:59:45 2007
> >> New Revision: 8424
> >>
> >> Modified:
> >>    trunk/libavformat/utils.c
> >>
> >> Log:
> >> add a delay variable to hold the timestamp buffer size
> >> set cur_dts correctly for delay>1
> >>
> >> [...]
> >> @@ -611,8 +612,7 @@ static void compute_pkt_fields(AVFormatC
> >>      }
> >>  
> >>      if(st->cur_dts == AV_NOPTS_VALUE){
> >> -        if(presentation_delayed) st->cur_dts = -pkt->duration;
> >> -        else                     st->cur_dts = 0;
> >> +        st->cur_dts = -delay * pkt->duration;
> >>      }
> >>  
> > 
> > Would adding a check for pkt->duration != AV_NOPTS_VALUE hurt here ?
> 
> err read != 0, Im not yet awake.

yes it would hurt, all code afterwards assumes cur_dts != AV_NOPTS_VALUE

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070320/c7e01fa4/attachment.pgp>