[Ffmpeg-cvslog] r8212 - trunk/libavformat/movenc.c

[Alex Beregszaszi]

Hi,

> >> -    put_be16(pb, track->mode == MODE_MOV ? track->enc->channels : 2); /* Number of channels */
> >> -    /* FIXME 8 bit for 'raw ' in mov */
> >> -    put_be16(pb, 16); /* Reserved */
> >> +    if (track->mode == MODE_MOV) {
> >> +        put_be16(pb, track->enc->channels);
> >> +        put_be16(pb, 16); /* FIXME 8 bit for 'raw ' in mov */
> >> +        put_be16(pb, track->audio_vbr ? -2 : 0); /* compression ID */
> >> +    } else { /* reserved for mp4/3gp */
> >> +        put_be16(pb, 2);
> > 
> > I think this should be changed to track->enc->channels and the next
> > field to track->enc->bits_per_sample.
> 
> NO !!! these fields are reserved for mp4/3gp.

Reserved to be set to 2 or zero? If the former, what happens in a mono
3gp file? Thats just plain broken.

--
Alex Beregszaszi