[FFmpeg-cvslog] r9281 - trunk/Makefile

[Ramiro Ribeiro Polla]

V?ctor Paesa wrote:
> Hi,
>
> On 6/15/07, Diego Biurrun wrote:
>   
>> On Tue, Jun 12, 2007 at 11:24:58AM +0200, V?ctor Paesa wrote:
>>     
>>> On 6/12/07, Diego Biurrun wrote:
>>>       
>>>> On Mon, Jun 11, 2007 at 12:44:58PM -0300, Ramiro Ribeiro Polla wrote:
>>>>         
>>>>> diego wrote:
>>>>>           
>>>>>> Log:
>>>>>> The video hooks do not depend on the libav* libraries.
>>>>>>             
>>>>> Actually, while working on vhooks for MinGW, and re-reading V?ctor's two
>>>>> month effort to get them working on Cygwin, vhooks do depend on the
>>>>> libav* libraries. Since I'm already trying to finish the integration for
>>>>> MinGW, I'll see how it can be set conditionally for Windows platforms.
>>>>>           
>>>> It sure compiles standalone here, so I'm very curious to see what you
>>>> are talking about.
>>>>         
>>> Broken here on Cygwin:
>>>
>>> $ ./configure --disable-static --enable-shared --enable-gpl --enable-swscaler
>>>
>>> $ make
>>>       
> [...]
>
>   
>>> gcc -Wl,--warn-common  -rdynamic -export-dynamic
>>> -Wl,-rpath-link,"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libavcodec
>>> -Wl,-rpath-link,"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libavformat
>>> -Wl,-rpath-link,"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libavutil -g -o
>>> null.dll -shared -L"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libavformat
>>> -L"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libavcodec
>>> -L"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libswscale
>>> -L"/home/wzrlpy/src/ffmpeg-9284/ffmpeg"/libavutil null.o -lavformat
>>> -lavcodec -lswscale -lavutil -lz
>>> gcc: unrecognized option `-rdynamic'
>>> /usr/lib/gcc/i686-pc-cygwin/3.4.4/../../../../i686-pc-cygwin/bin/ld:
>>> cannot find -lavformat
>>> collect2: ld returned 1 exit status
>>> make[1]: *** [null.dll] Error 1
>>> rm null.o
>>> make[1]: Leaving directory `/home/wzrlpy/src/ffmpeg-9284/ffmpeg/vhook'
>>> make: *** [videohook] Error 2
>>>
>>> Reverting the change fixes the build
>>> (with the unapproved llrintf() patch applied, of course).
>>>       
>> Try removing -lavformat from the link command manually.
>>     
>
> I'll give it a try this night, but I doubt it works: ld forbids
> undefined references
> in shared objects (for PE binaries, for ELF is OK).
>
>   

Hmm... I somehow missed the followups for this thread. Just saw them now.

Like V?ctor said, undefined references are forbidden in PE. That was 
(one of) the problem with linking vhooks statically. They would all be 
libavformat+libavcodec+vhook big, leaving us with 9mb for each vhook.
This is what [1] deals with. Ok to apply it?

Ramiro Polla
[1] http://article.gmane.org/gmane.comp.video.ffmpeg.devel/52177