[FFmpeg-cvslog] r9307 - in trunk/libavcodec: dsputil.c mpegvideo.c

[Reimar Doeffinger]

Hello,
On Thu, Jun 14, 2007 at 10:44:41AM +0200, diego wrote:
> Author: diego
> Date: Thu Jun 14 10:44:41 2007
> New Revision: 9307
> 
> Log:
> Simplify init preprocessor statements.
> patch by Albert Lee, trisk+xine acm.jhu edu
> 
> 
> Modified:
>    trunk/libavcodec/dsputil.c
>    trunk/libavcodec/mpegvideo.c
> 
> Modified: trunk/libavcodec/dsputil.c
> ==============================================================================
> --- trunk/libavcodec/dsputil.c	(original)
> +++ trunk/libavcodec/dsputil.c	Thu Jun 14 10:44:41 2007
> @@ -4138,31 +4138,23 @@ void dsputil_init(DSPContext* c, AVCodec
>      memset(c->put_2tap_qpel_pixels_tab, 0, sizeof(c->put_2tap_qpel_pixels_tab));
>      memset(c->avg_2tap_qpel_pixels_tab, 0, sizeof(c->avg_2tap_qpel_pixels_tab));
>  
> -#ifdef HAVE_MMX
> +#if defined(HAVE_MMX)
>      dsputil_init_mmx(c, avctx);
> -#endif
> -#ifdef ARCH_ARMV4L
> +#elif defined(ARCH_ARMV4L)
>      dsputil_init_armv4l(c, avctx);
> -#endif

> -#ifdef HAVE_MLIB
> +#elif defined(HAVE_MLIB)
>      dsputil_init_mlib(c, avctx);
> -#endif
> -#ifdef ARCH_SPARC
> +#elif defined(ARCH_SPARC)
>     dsputil_init_vis(c,avctx);
> -#endif

Are you sure about that? I would have thought this was on purpose,
because it would allow (as a made-up example) to use full optimizations
if only some dsp functions are optimized via SPARC asm and some via
MLIB.

Greetings,
Reimar Doeffinger