[FFmpeg-cvslog] r9734 - trunk/libavutil/aes.c

[Uoti Urpala]

On Thu, 2007-07-19 at 08:53 +0100, M?ns Rullg?rd wrote:
> >  typedef struct AVAES{
> > +    // Note: round_key[16] is accessed in the init code, but this only
> > +    // overwrites state, which does not matter (see also r7471).
> >      uint8_t round_key[15][4][4];
> >      uint8_t state[2][4][4];
> 
> Are you sure these arrays will always be ordered the same way on the stack?

That is a struct, and the standard does guarantee "If the objects
pointed to are members of the same aggregate object, pointers to
structure members declared later compare greater than pointers to
members declared earlier in the structure,". If you mean that the
compiler might use a representation differing from the normal struct
layout when it can prove no such comparisons are made then I suppose
that would be legal according to the standard but doesn't sound too
likely.