[FFmpeg-cvslog] r9734 - trunk/libavutil/aes.c

[Måns Rullgård]

reimar <subversion at mplayerhq.hu> writes:

> Author: reimar
> Date: Wed Jul 18 14:22:07 2007
> New Revision: 9734
>
> Log:
> Document aes init code writing on purpose beyond round_key array into state array.
>
> Modified:
>    trunk/libavutil/aes.c
>
> Modified: trunk/libavutil/aes.c
> ==============================================================================
> --- trunk/libavutil/aes.c	(original)
> +++ trunk/libavutil/aes.c	Wed Jul 18 14:22:07 2007
> @@ -24,6 +24,8 @@
>  #include "aes.h"
>
>  typedef struct AVAES{
> +    // Note: round_key[16] is accessed in the init code, but this only
> +    // overwrites state, which does not matter (see also r7471).
>      uint8_t round_key[15][4][4];
>      uint8_t state[2][4][4];

Are you sure these arrays will always be ordered the same way on the stack?

-- 
M?ns Rullg?rd
mans at mansr.com