[FFmpeg-cvslog] r9000 - trunk/libavcodec/i386/dsputil_mmx.c

[Michael Niedermayer]

Hi

On Mon, Jul 16, 2007 at 08:05:36PM +0200, Ivo wrote:
> On Monday 16 July 2007 19:28, Dominik 'Rathann' Mierzejewski wrote:
> > On Monday, 16 July 2007 at 12:11, Ivo wrote:
> > > On Saturday 12 May 2007 03:16, lorenm wrote:
> > > > Author: lorenm
> > > > Date: Sat May 12 03:16:06 2007
> > > > New Revision: 9000
> > > >
> > > > Log:
> > > > sse2 & ssse3 versions of hadamard. unroll and inline diff_pixels.
> > > > core2: before mmx2=193 cycles. after mmx2=174 sse2=122 ssse3=115
> > > > (cycles). k8: before mmx2=205. after mmx2=184 sse2=180.
> > > > p4: before mmx2=342. after mmx2=314 sse2=309.
> > > >
> > > >
> > > > Modified:
> > > >    trunk/libavcodec/i386/dsputil_mmx.c
> > >
> > > This breaks compilation with gcc 2.95.3:
> > >
> > > /opt/gcc-2.95.3/bin/gcc -I"/misc4/ffmpeg"/libswscale
> > > -I"/misc4/ffmpeg"/libavcodec  -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64
> > > -D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE -I"/misc4/ffmpeg"
> > > -I"/misc4/ffmpeg" -I"/misc4/ffmpeg"/libavutil -fomit-frame-pointer -g
> > > -Wall -Wno-switch -Wpointer-arith -Wredundant-decls -O3  -c -o
> >
> > Try without -g.
> 
> That does not help. But changing -O3 to -O0 does. -O1 still gives the same 
> error, with or without -g.

@@ -1527,7 +1527,7 @@
         "mov"#m1" "#mm"0, %0          \n\t"\
         DIFF_PIXELS_1(m0, mm##7, mm##0, (%1,%3,4), (%2,%3,4))\
         "mov"#m1" %0, "#mm"0          \n\t"\
-        : "=m"(temp), "+r"(p1b), "+r"(p2b)\
+        : "+m"(temp), "+r"(p1b), "+r"(p2b)\
         : "r"((long)stride), "r"((long)stride*3)\
     );\
 }

makes it compile, but its not correct, this looks like a gcc bug ...
id suggest to put the code under ifdef to prevent gcc 2.95 from
compiling it unless someone can figure out a clean workaround

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070716/c645a555/attachment.pgp>