[FFmpeg-cvslog] r9601 - trunk/libavcodec/mpegidct.c

[Carl Eugen Hoyos]

Hi!

On 2007-07-11 23:37, Diego Biurrun wrote:
> On Thu, Jul 12, 2007 at 02:09:28AM +0300, Ivan Kalvachev wrote:
> > 2007/7/12, Ivan Kalvachev <ikalvachev@???>:
> > > 2007/7/12, Diego Biurrun <diego@???>:
> > > > On Thu, Jul 12, 2007 at 12:01:21AM +0200, iive wrote:
> > > > >
> > > > > Log:
> > > > > Inport the original intiger IDCT from MPEG2 reference decoder.
> > > > > It passes IEEE1180 requirements.
> > > > >
> > > > > --- (empty file)
> > > > > +++ trunk/libavcodec/mpegidct.c       Thu Jul 12 00:01:21 2007
> > > > > @@ -0,0 +1,211 @@
> > > > > +/* idct.c, inverse fast discrete cosine transform                           */
> > > > > +
> > > > > +/* Copyright (C) 1996, MPEG Software Simulation Group. All Rights Reserved. */
> > > > > +
> > > > > +/*
> > > > > + * Disclaimer of Warranty
> > > > > + *
> > > > > + * These software programs are available to the user without any license fee or
> > > > > + * royalty on an "as is" basis.  The MPEG Software Simulation Group disclaims
> > > > > + * any and all warranties, whether express, implied, or statuary, including any
> > > > > + * implied warranties or merchantability or of fitness for a particular
> > > > > + * purpose.  In no event shall the copyright-holder be liable for any
> > > > > + * incidental, punitive, or consequential damages of any kind whatsoever
> > > > > + * arising from the use of these programs.
> > > > > + *
> > > > > + * This disclaimer of warranty extends to the user of these programs and user's
> > > > > + * customers, employees, agents, transferees, successors, and assigns.
> > > > > + *
> > > > > + * The MPEG Software Simulation Group does not represent or warrant that the
> > > > > + * programs furnished hereunder are free of infringement of any third-party
> > > > > + * patents.
> > > > > + *
> > > > > + * Commercial implementations of MPEG-1 and MPEG-2 video, including shareware,
> > > > > + * are subject to royalty fees to patent holders.  Many of these patents are
> > > > > + * general enough such that they are unavoidable regardless of implementation
> > > > > + * design.
> > > > > + */
> > > >
> > > > This is clearly non-free.  What were you thinking ?!?
> > >
> > > My mistake. I thought it is public domain.
> > 
> > At least 2 other GPL project use same routine and have same header in it.
> > http://cvs.xvid.org/cvs/viewvc.cgi/xvidcore/src/dct/idct.c?view=log
> 
> Which one is the second?
> 
> Point this foolishness out to them, they should get their act together
> ASAP.  Is this file compiled into the Xvid library?

Yes.

I tried nm /usr/lib/libxvidcore.a | grep idct_int32 on the version
installed on my system (xvid 1.1.2-0.pm.1).
I then downloaded xvidcore-1.1.3 and xvid_20070712 and both include
idct.o in their library when built with ./configure without any other
options.

Carl Eugen