[FFmpeg-cvslog] r9547 - in trunk/libavcodec: cavs.h h264.c mpegvideo.h snow.c

[Roman Shaposhnik]

Hi

On Mon, 2007-07-09 at 22:05 +0100, M?ns Rullg?rd wrote:
> >> So what do we do with this function?  Make it "extern inline"?  Move
> >> it to a header as "static inline"?
> >
> > hmm id say Move it to a header as "static inline"
> 
> Something like this then?

  Yes, but keeping ff_h263_chroma_roundtab[] separate from the
function itself might be more trouble than it is worth. Something
like:

static inline int ff_h263_round_chroma(int x){
    static const unsigned char ff_h263_chroma_roundtab[16]...

seems to be more efficient (at least with Sun Studio) and easier 
to digest.

Thanks,
Roman.

P.S. Although it is a bit sad, that gcc seems to be playing
stupid with the above definition of ff_h263_round_chroma :-(