[FFmpeg-cvslog] r9447 - trunk/libavcodec/wmv2.c

[Michael Niedermayer]

Hi

On Tue, Jul 03, 2007 at 04:42:33PM +0200, Benoit Fouet wrote:
> Michael Niedermayer wrote:
> > Hi
> >
> > On Tue, Jul 03, 2007 at 11:09:12AM +0200, Benoit Fouet wrote:
> >   
> >> Panagiotis Issaris wrote:
> >>     
> >>> Hi,
> >>>
> >>> Ivan Kalvachev wrote:
> >>>       
> >>>> 2007/6/27, Michael Niedermayer <michaelni at gmx.at>:
> >>>>         
> >>>>> Hi
> >>>>>
> >>>>> On Wed, Jun 27, 2007 at 04:27:48PM +0200, iive wrote:
> >>>>>           
> >>>>>> Author: iive
> >>>>>> Date: Wed Jun 27 16:27:47 2007
> >>>>>> New Revision: 9447
> >>>>>>
> >>>>>> Log:
> >>>>>> Identify the loop_filter flag as such and remove the unused
> >>>>>>             
> >>> variables in the context.
> >>>       
> >>>>> you are not wmv2 maintainer, you didnt send a patch,
> >>>>> you didnt provide any sample which shows artifacts without this
> >>>>> and i doubt it is correct as is, wmv2 likely doesnt use the h.263
> >>>>> loop filter
> >>>>>           
> >>>> Even using wrong deblocker on decoding gives much better results than
> >>>> not using any.
> >>>>         
> >>>> Encoding with loop_filter set to 1, as it was until now, whole not
> >>>> using any filtering at all is obviously wrong. I see encoding with
> >>>> enabled "loop_filter" is marked as problematic even for h263, so I
> >>>> don't see it as urgent problem.
> >>>> And yes,  sorry, it changes the regression, however the encoded file
> >>>> should differ in only 1 bit. The decoded output should stay the same.
> >>>>         
> >>> Should the attached patch be applied to fix the regression tests?
> >>>
> >>>       
> >> ping !
> >>     
> >
> > ok
> >
> > [...]
> >   
> 
> actually, i have the attached diff to fix regression tests

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070703/a5fa0e1a/attachment.pgp>