[Ffmpeg-cvslog] r7777 - trunk/libavcodec/lzo.c

[Reimar Doeffinger]

Hello,
On Wed, Jan 31, 2007 at 11:36:27AM +0100, Michael Niedermayer wrote:
> On Wed, Jan 31, 2007 at 11:29:58AM +0100, reimar wrote:
> > Author: reimar
> > Date: Wed Jan 31 11:29:58 2007
> > New Revision: 7777
> > 
> > Modified:
> >    trunk/libavcodec/lzo.c
> > 
> > Log:
> > Add two extra needed bounds checks
> 
> are they really needed?

The one before the continue yes. The one outside the loop should not
hurt either way.

> also we always seem to read one byte after copy() so we could just check that
> one more is available in copy ...

Probably. I admit I was trying to move the checks in copy() so that they
are only done for blocks > 4 bytes, then those would definitly be
needed, but I was not able to get a significant speedup up to now...

Greetings,
Reimar Doeffinger