[Ffmpeg-cvslog] r7765 - trunk/libavformat/avio.c

gpoirier subversion
Tue Jan 30 11:37:52 CET 2007


Author: gpoirier
Date: Tue Jan 30 11:37:52 2007
New Revision: 7765

Modified:
   trunk/libavformat/avio.c

Log:
protect the size=seek(SEEK_END,-1)+1 results with an if (.. < 0), else the
return value may still end up being zero (if the seek returns -1, which is
e.g. what file.c will return on error), which is a valid (but incorrect)
filesize.
Patch by Ronald S. Bultje % rbultje A ronald P bitfreak P net %
Original thread:
date: Jan 2, 2007 2:11 AM
subject: [Ffmpeg-devel] Re: [PATCH] file length handling


Modified: trunk/libavformat/avio.c
==============================================================================
--- trunk/libavformat/avio.c	(original)
+++ trunk/libavformat/avio.c	Tue Jan 30 11:37:52 2007
@@ -154,7 +154,9 @@
     size= url_seek(h, 0, AVSEEK_SIZE);
     if(size<0){
         pos = url_seek(h, 0, SEEK_CUR);
-        size = url_seek(h, -1, SEEK_END)+1;
+        if ((size = url_seek(h, -1, SEEK_END)) < 0)
+            return size;
+        size++;
         url_seek(h, pos, SEEK_SET);
     }
     return size;




More information about the ffmpeg-cvslog mailing list