[Ffmpeg-cvslog] r7678 - trunk/libavcodec/bmp.c

[Michael Niedermayer]

Hi

On Wed, Jan 24, 2007 at 11:51:26AM +0100, Michel Bardiaux wrote:
> michael wrote:
> >Author: michael
> >Date: Wed Jan 24 11:41:03 2007
> >New Revision: 7678
> >
> >Modified:
> >   trunk/libavcodec/bmp.c
> >
> >Log:
> >enum
> >
> >
> >Modified: trunk/libavcodec/bmp.c
> >==============================================================================
> >--- trunk/libavcodec/bmp.c	(original)
> >+++ trunk/libavcodec/bmp.c	Wed Jan 24 11:41:03 2007
> >@@ -27,10 +27,12 @@
> >     AVFrame picture;
> > } BMPContext;
> > 
> >-#define BMP_RGB       0
> >-#define BMP_RLE8      1
> >-#define BMP_RLE4      2
> >-#define BMP_BITFIELDS 3
> >+typedef enum {
> >+    BMP_RGB=0,
> >+    BMP_RLE8,
> >+    BMP_RLE4,
> >+    BMP_BITFIELDS,
> >+} BiCompression;
> 
> The values are mandated by MS specs, so IMHO they should all be forced, 
> or at least a comment to that effect.

done


> 
> Also, the same enum will be needed by the encoder, which will go in a 
> different file, so should the enum go to some bmp.h or to avcodec.h or what?

bmp.h

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070124/fc6b9d3c/attachment.pgp>