[Ffmpeg-cvslog] r7604 - trunk/libavformat/aiff.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sun, Jan 21, 2007 at 02:56:32PM +0100, Alex Beregszaszi wrote:
>> Hi,
>> 
>> > >> Modified: trunk/libavformat/aiff.c
>> > >> ==============================================================================
>> > >> --- trunk/libavformat/aiff.c	(original)
>> > >> +++ trunk/libavformat/aiff.c	Sun Jan 21 13:47:46 2007
>> > >> @@ -166,7 +166,6 @@
>> > >>  
>> > >>      /* First verify if format is ok */
>> > >>      if (!enc->codec_tag) {
>> > >> -        av_free(aiff);
>> > >>          return -1;
>> > >>      }
>> > >
>> > > And what about the useless {} ?
>> > 
>> > Useless but also harmless.
>
> yes and there are many of these, and iam unsure if its worth to remove
> them ...

They don't make the code any less readable, so I see little reason to
change it.  Saving a few bytes of source code size isn't that
important.

-- 
M?ns Rullg?rd
mru at inprovide.com