[Ffmpeg-cvslog] r7585 - trunk/libavcodec/h264.c

[Guillaume POIRIER]

Hi,

On 1/19/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Fri, Jan 19, 2007 at 01:21:19PM +0100, Guillaume POIRIER wrote:
> > Hi,
> >
> > On 1/19/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >On Fri, Jan 19, 2007 at 10:37:08AM +0100, gpoirier wrote:
> > >> --- trunk/libavcodec/h264.c   (original)
> > >> +++ trunk/libavcodec/h264.c   Fri Jan 19 10:37:04 2007
> > >[...]
> > >> @@ -4521,8 +4532,8 @@
> > >>          return -1;
> > >>      }
> > >>
> > >> -    if(h->dequant_coeff_pps != pps_id){
> > >> -        h->dequant_coeff_pps = pps_id;
> > >> +    if(h->dequant_coeff_pps != (int)pps_id){
> > >> +        h->dequant_coeff_pps = (int)pps_id;
> > >
> > >argh ...
> >
> > Sorry, I had not understand that this hunk wasn't ok when I read your
> > answer.
> > Should I revert that very hunk? I guess the answer is yes, but I
> > prefer to ask before doing anything.
>
> hmm as you ask ... well ... why not implement paff support? and we
> forget about this little mistake ;))))

Well, I'm really honored that you think of me to implement paff
support. My coding capabilities being as they are, I think it's safe
to say that I may be done with implementing paff support when pigs can
fly. If you're not in a hurry, I can surely do that! ;-)

> failing that ... yes iam happy too if you reverse this hunk

Done :)

Guillaume