[Ffmpeg-cvslog] r7537 - trunk/libavformat/avidec.c

[Michael Niedermayer]

Hi

On Tue, Jan 16, 2007 at 12:12:15AM +0100, Guillaume POIRIER wrote:
> Hi,
> 
> On 1/15/07, michael <subversion at mplayerhq.hu> wrote:
> 
> >fixing segfault with http://sam.zoy.org/zzuf/lol-ffplay.avi
> 
> >--- trunk/libavformat/avidec.c  (original)
> >+++ trunk/libavformat/avidec.c  Mon Jan 15 23:56:46 2007
> >@@ -397,7 +397,7 @@
> >             break;
> >         case MKTAG('s', 't', 'r', 'f'):
> >             /* stream header */
> >-            if (stream_index >= s->nb_streams || avi->dv_demux) {
> >+            if (stream_index >= (unsigned)s->nb_streams || avi->dv_demux) 
> >{
> >                 url_fskip(pb, size);
> >             } else {
> 
> That's interesting: why this fix instead of defining nb_streams struct
> member as unsigned int?
> 
> Wouldn't that be more logical?

hmm maybe, feel free to change it to unsigned ... (dont forget the regression
tests)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070116/cd3bd5ad/attachment.pgp>