[Ffmpeg-cvslog] r8123 - trunk/libavformat/swf.c

[Baptiste Coudurier]

Hi

Michael Niedermayer a ?crit :
> Hi
> 
> On Sun, Feb 25, 2007 at 03:13:13PM +0100, alex wrote:
>> Author: alex
>> Date: Sun Feb 25 15:13:12 2007
>> New Revision: 8123
>>
>> Modified:
>>    trunk/libavformat/swf.c
>>
>> Log:
>> use AV_RB32, 
> 
> fine but
> 
>> swf_mp3_info may be replaced with mpa_decoder_header
> 
> NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!!!!!!!!!!!!!!!!!!
> the broken swf muxer has no business with the mp3 headers this is all
> deeply broken none of it is needed, the swf muxer should just take the
> packets as is and store them or if needed reorder them by implementing
> interleave_packet() or merge and split them with a fifo but i dont
> think thats what is needed

Well, actually it seems needed for swf, you need to pack mp3 frames with 
a video frame, and put correct samples number (enc->frame_size * 
frames_nb). I have something working pending, will post it soon.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no