[Ffmpeg-cvslog] r8124 - in trunk/libavcodec: vp5.c vp56.c vp56.h vp56data.h vp6.c

[Aurelien Jacobs]

On Sun, 25 Feb 2007 17:26:32 +0100
"Guillaume POIRIER" <poirierg at gmail.com> wrote:

> Hi,
> 
> On 2/25/07, aurel <subversion at mplayerhq.hu> wrote:
> 
> > Log:
> > Use pointers to avoid copying AVFrame.
> > This ensure get_buffer() won't be confused with an AVFrame pointer
> > which looks like it wasn't released.
> 
> Were you able to measure some speed-up as a result of this change?

No and that was not the point.
The point was to remove such a line:
  s->frames[VP56_FRAME_CURRENT].data[0] = NULL;
which were there to trick get_buffer(), to make it think that frame
was properly released.

Note that AVFrame don't contains the frame data itself (the content
of the YUV plans). It is only a small structure containing a few
pointers. Copying it 2 or 3 times per frame was really not speed
critical.

Aurel