[Ffmpeg-cvslog] r7753 - trunk/libavcodec/cook.c

[Benjamin Larsson]

Dominik 'Rathann' Mierzejewski wrote:
> On Monday, 29 January 2007 at 09:37, banan wrote:
>> Author: banan
>> Date: Mon Jan 29 09:37:22 2007
>> New Revision: 7753
>>
>> Modified:
>>    trunk/libavcodec/cook.c
>>
>> Log:
>> decode_subpacket cleanup by Ian Braithwaite ian braithwaite dot dk.
>>
>>
>> Modified: trunk/libavcodec/cook.c
>> ==============================================================================
>> --- trunk/libavcodec/cook.c	(original)
>> +++ trunk/libavcodec/cook.c	Mon Jan 29 09:37:22 2007
>> @@ -50,6 +50,7 @@
>>  #include "avcodec.h"
>>  #include "bitstream.h"
>>  #include "dsputil.h"
>> +#include "common.h"
>>  
>>  #include "cookdata.h"
>>  
>> @@ -112,13 +113,12 @@
>>      int                 mlt_size;       //modulated lapped transform size
>>  
>>      /* gain buffers */
>> -    COOKgain*           gain_now_ptr;
>> -    COOKgain*           gain_previous_ptr;
>> -    COOKgain            gain_current;
>> -    COOKgain            gain_now;
>> -    COOKgain            gain_previous;
>> -    COOKgain            gain_channel1[2];
>> -    COOKgain            gain_channel2[2];
>> +    COOKgain            *gain_ptr1[2];
>> +    COOKgain            *gain_ptr2[2];
>> +    COOKgain            gain_1;
>> +    COOKgain            gain_2;
>> +    COOKgain            gain_3;
>> +    COOKgain            gain_4;
> 
> Would it not be cleaner to have:
>> +    COOKgain            *gain_ptr[2][2];
>> +    COOKgain            gain[4];
> 
> ?

Patch welcome.

MvH
Benjamin Larsson