[Ffmpeg-cvslog] r7994 - trunk/libavcodec/i386/h264dsp_mmx.c

[Michael Niedermayer]

Hi

On Sun, Feb 18, 2007 at 12:09:25AM +0200, Ivan Kalvachev wrote:
> 2007/2/16, michael <subversion at mplayerhq.hu>:
> >Author: michael
> >Date: Fri Feb 16 22:22:53 2007
> >New Revision: 7994
> >
> >Modified:
> >   trunk/libavcodec/i386/h264dsp_mmx.c
> >
> >Log:
> >add a few asserts to ensure alignment
> >
> >
> >Modified: trunk/libavcodec/i386/h264dsp_mmx.c
> >==============================================================================
> >--- trunk/libavcodec/i386/h264dsp_mmx.c (original)
> >+++ trunk/libavcodec/i386/h264dsp_mmx.c Fri Feb 16 22:22:53 2007
> >@@ -1311,6 +1311,7 @@
> >     uint64_t temp[SIZE*(SIZE<8?12:24)/4 + SIZE*SIZE/8];\
> >     uint8_t * const halfHV= (uint8_t*)temp;\
> >     int16_t * const tmp= ((int16_t*)temp) + SIZE*SIZE/2;\
> >+    assert((int)temp & 7 == 0);\
> 
> Why release quality code should abort() on none-SSE cpu because of
> unaligned MMX access?
> 
> You can simply define and use aligned temp[] array in the dspcontext!

send patch and benchmark

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070218/2808d1ed/attachment.pgp>