[Ffmpeg-cvslog] r7889 - trunk/libavcodec/mpeg12.c

[Ivan Kalvachev]

2007/2/9, michael <subversion at mplayerhq.hu>:
> Author: michael
> Date: Fri Feb  9 03:21:34 2007
> New Revision: 7889
>
> Modified:
>    trunk/libavcodec/mpeg12.c
>
> Log:
> fix segfault with lol-ffplay2.mpg (dunno if this is exploitable, probably not easily)
>
>
> Modified: trunk/libavcodec/mpeg12.c
> ==============================================================================
> --- trunk/libavcodec/mpeg12.c   (original)
> +++ trunk/libavcodec/mpeg12.c   Fri Feb  9 03:21:34 2007
> @@ -2593,6 +2593,10 @@
>              break;
>          }
>      }
> +    if(s->mb_x >= (unsigned)s->mb_width){
> +        av_log(s->avctx, AV_LOG_ERROR, "initial skip overflow\n");
> +        return -1;
> +    }
>
>      s->resync_mb_x= s->mb_x;
>      s->resync_mb_y= s->mb_y= mb_y;

Are you sure this is error condition?

I don't see anything in mpeg standards that indicates so. even contrary.