[Ffmpeg-cvslog] r7876 - trunk/libavformat/avidec.c

[Michael Niedermayer]

Hi

On Wed, Feb 07, 2007 at 08:35:02PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Wed, Feb 07, 2007 at 08:27:54PM +0100, Michael Niedermayer wrote:
> > On Wed, Feb 07, 2007 at 07:19:39PM +0100, Reimar D?ffinger wrote:
> > > On Wed, Feb 07, 2007 at 06:56:31PM +0100, michael wrote:
> > > > Author: michael
> > > > Date: Wed Feb  7 18:56:31 2007
> > > > New Revision: 7876
> > > > 
> > > > Modified:
> > > >    trunk/libavformat/avidec.c
> > > > 
> > > > Log:
> > > > supporting files with A,V,I,0x19  header
> > > > 
> > > > 
> > > > Modified: trunk/libavformat/avidec.c
> > > > ==============================================================================
> > > > --- trunk/libavformat/avidec.c	(original)
> > > > +++ trunk/libavformat/avidec.c	Wed Feb  7 18:56:31 2007
> > > > @@ -82,6 +82,9 @@
> > > >      avi->riff_end = get_le32(pb);   /* RIFF chunk size */
> > > >      avi->riff_end += url_ftell(pb); /* RIFF chunk end */
> > > >      tag = get_le32(pb);
> > > > +    if(tag == MKTAG('A', 'V', 'I', 0x19))
> > > > +        av_log(NULL, AV_LOG_INFO, "file has been generated with a totally broken muxer\n");
> > > > +    else
> > > 
> > > Are you sure it's that? I actually expected that this is some stupid
> > > hack to force people to install and use only a specific software.
> > > Somehow similar to that format where they put the whole 100 MB MPEG2
> > > stream into one AVI data chunk...
> > 
> > which too is broken and invalid
> > 
> > and heres the avi spec from MS:
> [...]
> 
> Really, no disagreement here nor with the commit, my mail was just loud
> wondering, like "I wonder if this was supposed to be some poor man's
> DRM".
> I mean, to me it sounded a bit like you found it possible to be an accident,
> which I somehow doubt 

if they wanted their format to be unplayable by others why change just a
single byte? i would have at least changed the whole tag or better yet
a few tags or even better change the structure of the file ...

> (though I wonder, can Windows Media Player or some
> such play it?)

dunno

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070207/a50c3cac/attachment.pgp>