[FFmpeg-cvslog] r11225 - trunk/libavformat/avformat.h

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Dec 16, 2007 at 11:40:05PM +0000, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Sun, Dec 16, 2007 at 10:52:23PM +0000, M?ns Rullg?rd wrote:
>> >> Michael Niedermayer <michaelni at gmx.at> writes:
>> >> 
>> >> > On Sun, Dec 16, 2007 at 06:22:09PM +0100, Diego Biurrun wrote:
>> >> >> On Sat, Dec 15, 2007 at 05:54:59PM +0100, michael wrote:
>> >> >> > 
>> >> >> > Log:
>> >> >> > document how to free the result of av_alloc_format_context()
>> >> >> > 
>> >> >> > --- trunk/libavformat/avformat.h	(original)
>> >> >> > +++ trunk/libavformat/avformat.h	Sat Dec 15 17:54:58 2007
>> >> >> > @@ -569,7 +569,11 @@ int av_open_input_file(AVFormatContext *
>> >> >> > +/**
>> >> >> > + * Allocate an AVFormatContext.
>> >> >> > + * can be freed with av_free() but dont forget to free everything you
>> >> >> > + * explicitly allocated as well!
>> >> >> 
>> >> >> Could you please make an effort to avoid obvious misspellings
>> >> >> ("dont")?  It took some work to fix these things up in FFmpeg
>> >> >> and it would be a pity to let it go to waste again.
>> >> >
>> >> > feel free to improve the precommit check script
>> >> 
>> >> I have to say, this attitude of yours is starting to get quite tiresome.
>> >
>> > Very much so.  I don't understand why you are such a complete
>> > perfectionist about what code is acceptable for FFmpeg and at the
>> > same time disregard the quality of the (Doxygen) documentation.
>
> because "dont" is as readable with as well as without some little
> speck between n and t, buggy, slow, bloated, ... code though has a
> quite noticeable effect, take a look at our bugtracker how many bugs
> are there about spelling and grammer and how many are there about
> other things

Am I the only one who struggles to read Michaels streams of words,
totally void of all structure and punctuation?

> i prefer to concentrate on fixing things which do matter to our
> developers and users, over things which dont and belive it or not
> reading everything twice to fix spelling capitalization and all that
> takes time, time i could spent fixing some issues

So readable documentation doesn't matter?  I find it odd that you
insist on Doxygen comments everywhere, yet pay little or no attention
to making these comments even remotely comprehensible, except possibly
to yourself.

> also ive a suggestion, ill be more carefull with my spelling and you fix
> a few issues on our bugtracker (and no i dont mean closing invalid ones but
> real bugfixes which require a change of the C code)
> i think that would be fair, it would require each of us to do something
> we dont commonly do

Some us here have jobs to attend in the daytime, and thus have much
less time to spend coding on FFmpeg.  Please keep that in mind before
accusing people of being lazy.

>> How about we start committing random broken code with the excuse that
>> "Michael will fix it"?
>
> i would by reverting and asking root to remove your write access

Ah, but root doesn't take orders like that.

-- 
M?ns Rullg?rd
mans at mansr.com