[FFmpeg-cvslog] r11202 - trunk/configure

[Michael Niedermayer]

On Wed, Dec 12, 2007 at 02:24:21PM -0500, Rich Felker wrote:
> On Wed, Dec 12, 2007 at 07:16:11PM +0100, Michael Niedermayer wrote:
> > On Wed, Dec 12, 2007 at 12:15:22PM -0500, Rich Felker wrote:
> > > On Wed, Dec 12, 2007 at 11:57:11AM -0000, M?ns Rullg?rd wrote:
> > > > I see.  Yes, that's probably possible, though I'd rather not spend time
> > > > figuring out how to do it if we can get rid of these exports more easily.
> > > 
> > > Indeed. Despite the binutils bug, we should be visciously removing any
> > > public global vars anyway. They have high program startup cost
> > > regardless of what linking mode is used (copy relocations or textrels
> > > in the main program).
> > > 
> > > If access to them is really needed, make a function that returns a
> > > (hopefully const-qualified) pointer to the data. But I can't imagine
> > > why a legitimate program would be peeking directly at these data
> > > structures..
> > 
> > some examples where this is currently used are
> > 
> > av_log_level
> > av_vlog
> > currently we have wraper functions for these to set/get them
> > originally i wanted to drop these functions, as can be seen by the
> > #if LIBAVUTIL_VERSION_INT in log.{c,h}
> > i guess we should just leave the more complex API or do you suggest that
> > we change it to 2 functions to returning pointers to av_log_level and av_vlog?
> 
> I thought that stuff had been fixed to use the context and not global
> vars....

using the context is inconvenient
you would have to set the callback for every codec, muxer, demuxer, ...
if you miss one output goes to stderr, also there are a few av_log(NULL, ...
they wont work with whats in the contexts


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker, user
questions for the command line tools ffmpeg, ffplay, ... as well as questions
about how to use libav* should be sent to the ffmpeg-user mailinglist.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071212/a46317c1/attachment.pgp>