[FFmpeg-cvslog] r10257 - trunk/libavformat/rtp_mpv.c

[Michael Niedermayer]

Hi

On Wed, Aug 29, 2007 at 02:02:28AM +0200, Luca Barbato wrote:
> Luca Abeni wrote:
> >>    trunk/libavformat/rtp_mpv.c
> > So, now my patches do not apply anymore :(
> 
> Sorry, as I said in the other thread, I applied this change and then
> looked at your proposed patch...
> 
> > 
> > As far as I can see, the patch you committed
> > - packetizes in the wrong way frames containing more than 1 slice 
> > - always sets the "B" bit, even if the packet does not start with the
> > beginning of a slice
> > - only sets the "E" bit in the correct way if the frame is composed by
> > only 1 slice
> > 
> 
> What is committed is the minimal change to have most of the demuxers
> happy and working. The mpegvideo->rtp rfc is quite problematic and
> mandates to recover&send informations you shouldn't know and that do not
> interest the client that much.

the slice start/end should be known as keeping slices in one piece
improves error resilience if some are lost ...

reproducing random bits from the header in every packet of course is
silly but this again leads to the flame about rt*p bein misdesigned
if you want to provide error resilience for the case that the header
is lost you well ... repeat the header not duplicate it per packet
in a incompatible format


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070829/66faffe6/attachment.pgp>