[FFmpeg-cvslog] r10223 - in trunk/libavcodec/i386: dsputil_mmx.c snowdsp_mmx.c

[Michael Niedermayer]

Hi

On Mon, Aug 27, 2007 at 11:34:44PM +0200, Michael Niedermayer wrote:
[...]
> > 
> > > > -             "punpckhwd %%xmm7, %%xmm1       \n\t"
> > > > -             "punpcklwd %%xmm7, %%xmm2       \n\t"
> > > > -             "paddd %%xmm2, %%xmm0           \n\t"
> > > > -             "movdqa 16(%%"REG_D"), %%xmm2   \n\t"
> > > > -             "paddd %%xmm1, %%xmm2           \n\t"
> > > > +             "paddd %%xmm1, %%xmm0           \n\t"
> > > 
> > > no, these are 16 not 32 bit
> > 
> > Obviously.
> > 
> > > also theres some shift by 4 missing here
> > 
> > I don't think so, there is a "psraw $4, %%xmm0               \n\t"
> > further down. And I know the code is an unreadable mess. I'll try to
> > reimplement it somewhen if noone else will do it...
> 
> the daa after obmc is 16bit unsigned, the data after the IDWT is 13bit

note, the 13bit is theoretical, it can due to rounding and quantizatio
be larger

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070827/6b6afdd3/attachment.pgp>