[FFmpeg-cvslog] r10201 - in trunk/libavformat: Makefile rtp.c rtp_internal.h rtp_mpv.c rtp_mpv.h

[Diego Biurrun]

On Fri, Aug 24, 2007 at 11:09:47AM +0200, Luca Abeni wrote:
> 
> Diego Biurrun wrote:
> > On Fri, Aug 24, 2007 at 09:13:34AM +0200, lucabe wrote:
> >> Log:
> >> Move the RTP packetization code for MPEG12 video in its own file (rtp_mpv.c)
> [...]
> >> - * RTP input/output format
> >> + * RTP packetization for MPEG video
> >>   * Copyright (c) 2002 Fabrice Bellard.
> > 
> > I do not think this was written by Fabrice, why does it have his
> > copyright?
> 
> It's a copy of the original function (written by Fabrice, according to 
> rtp.c's copyright). I just moved the function to a new file, and I did 
> not think that this would change the copyright.
> Anyway, let me know what should be done and I'll fix the header.

Was it written by Fabrice according to the Subversion log as well?

> >> Added: trunk/libavformat/rtp_mpv.h
> >> ==============================================================================
> >> --- (empty file)
> >> +++ trunk/libavformat/rtp_mpv.h	Fri Aug 24 09:13:34 2007
> >> @@ -0,0 +1,26 @@
> >> +/*
> >> + * RTP definitions
> >> + * Copyright (c) 2002 Fabrice Bellard.
> > 
> > And this was definitely not written by Fabrice.
> 
> The file only contains the prototype of a C function. I do not think 
> that copyrights apply to function's prototypes, but I had to put a 
> copyright header in the file...
> So, I wrote the name of the person who wrote the function's body. I 
> apologize if this was an error.
> So, should I remove Fabrice's name, and write my one? Or add my name 
> after Fabrice's one? Or simply remove the "Copyright (c)" line (I think 
> the LGPL wants it, but I might be wrong)?

For such a triviality you can probably safely remove the line IMO.

Diego