[FFmpeg-cvslog] r10108 - trunk/doc/ffmpeg-doc.texi
diego
subversion
Tue Aug 14 00:15:48 CEST 2007
Author: diego
Date: Tue Aug 14 00:15:48 2007
New Revision: 10108
Log:
Attempt to better explain how to split patches into individual
self-contained pieces.
Modified:
trunk/doc/ffmpeg-doc.texi
Modified: trunk/doc/ffmpeg-doc.texi
==============================================================================
--- trunk/doc/ffmpeg-doc.texi (original)
+++ trunk/doc/ffmpeg-doc.texi Tue Aug 14 00:15:48 2007
@@ -1673,9 +1673,12 @@ First, (@pxref{Coding Rules}) above if y
When you submit your patch, try to send a unified diff (diff '-up'
option). We cannot read other diffs :-)
-Also please do not submit patches which contain several unrelated changes.
-Split them into individual self-contained patches; this makes reviewing
-them much easier.
+Also please do not submit a patch which contains several unrelated changes.
+Split it into separate, self-contained pieces. This does not mean splitting
+file by file. Instead, make the patch as small as possible while still
+keeping it as a logical unit that contains an individual change, even
+if it spans multiple files. This makes reviewing your patches much easier
+for us and greatly increases your chances of getting your patch applied.
Run the regression tests before submitting a patch so that you can
verify that there are no big problems.
More information about the ffmpeg-cvslog
mailing list