[FFmpeg-cvslog] r9992 - in trunk: ffserver.c libavformat/os_support.h

[Michael Niedermayer]

Hi

On Sat, Aug 11, 2007 at 07:47:48PM -0300, Ramiro Polla wrote:
> Michael Niedermayer wrote:
>> Hi
>>
>> On Sat, Aug 11, 2007 at 06:07:54PM -0300, Ramiro Polla wrote:
>>   
>>> Could this patch be reviewed, please? MinGW is currently broken because 
>>> of this.
>>>     
>>
>> patch rejected
>>
>> a simple #define closesocket close
>> worked before, now it stopped working, you dont even explain why but just
>> want to add bloat to workaround it by adding an unneeded function ...
>> if it where a static inline in a header but its not
>>
>> and of cousrse must this closesocket() not be exported
>>
>> id say just revert the untested changes which caused this or fix the code
>> (maybe moving the #define closesocket would fix it?)
>>
>>   
>
> Thanks for reviewing. After a closer inspection I figured that patch was 
> even wronger. closesocket() was not being found because the check in 
> configure wasn't suited for Windows.
>
> New simpler patch attached.

this looks much better, but iam not configure maintainer ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070812/5705781f/attachment.pgp>