[FFmpeg-cvslog] r9995 - trunk/libavcodec/wavpack.c

[Michael Niedermayer]

Hi

On Fri, Aug 10, 2007 at 02:20:33PM +0200, Alex Beregszaszi wrote:
> Hi,
> 
> On Thu, 2007-08-09 at 11:18 +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Thu, Aug 09, 2007 at 04:09:40AM +0200, Michael Niedermayer wrote:
> > > Hi
> > > 
> > > On Thu, Aug 09, 2007 at 12:36:12AM +0200, alex wrote:
> > > > Author: alex
> > > > Date: Thu Aug  9 00:36:12 2007
> > > > New Revision: 9995
> > > > 
> > > > Log:
> > > > use get_unary from bitstream.h
> > > 
> > > what effect does this have on speed?
> > > 
> > 
> > > and object size with --enable-small?
> > 
> > -rw-r----- 1 michael michael 38300 2007-08-09 11:12 wavpack-alex.o
> > -rw-r----- 1 michael michael 38148 2007-08-09 11:13 wavpack.o
> > 
> > compiled with -O3 -Os -DCONFIG_SMALL -Dav_always_inline=/**/ which should be
> > what config_small does
> 
> Reverse the commit ASAP!

why dont you revert your commit yourself?
or even better why did you not think about it before commiting


> 
> Now did you read what I wrote? We should enable the OPEN_READER based
> version, which should be faster anyway.

i did read what you wrote, did you read what i wrote about sending patches
for code maintained by others?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070810/42bc9f4f/attachment.pgp>