[FFmpeg-cvslog] r9881 - trunk/ffmpeg.c

[Michael Niedermayer]

Hi

On Sun, Aug 05, 2007 at 04:10:15AM +0200, Baptiste Coudurier wrote:
> Hi Michael,
> 
> michael wrote:
> > Author: michael
> > Date: Sat Aug  4 01:25:03 2007
> > New Revision: 9881
> > 
> > Log:
> > drop non keyframes before the first keyframe for stream copy
> > 
> > 
> > Modified:
> >    trunk/ffmpeg.c
> > 
> > Modified: trunk/ffmpeg.c
> > ==============================================================================
> > --- trunk/ffmpeg.c	(original)
> > +++ trunk/ffmpeg.c	Sat Aug  4 01:25:03 2007
> > @@ -1210,6 +1210,9 @@ static int output_packet(AVInputStream *
> >                          AVPacket opkt;
> >                          av_init_packet(&opkt);
> >  
> > +                        if (!ost->frame_number && !(pkt->flags & PKT_FLAG_KEY))
> > +                            continue;
> > +
> >                          /* no reencoding needed : output the packet directly */
> >                          /* force the input stream PTS */
> >  
> 
> That may be a bit harsh. For example swf does not have any information
> about key frame/pict type for flv, since there is no parser, no frames
> are flagged as key frames, therefore you cannot stream copy essence.
> 
> What do you think ?

well -ss X -vcodec copy needs to know key frames the added check doesnt
change that, it just changes generating a broken video into generating no
video ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070805/3b1667e2/attachment.pgp>