[FFmpeg-cvslog] r9848 - trunk/libavcodec/ac3dec.c

[Michael Niedermayer]

Hi

On Thu, Aug 02, 2007 at 06:08:49PM +0200, Benjamin Larsson wrote:
> Michael Niedermayer skrev:
> >> Sure looks ok, this will save us some future bugreports.
> >>     
> >
> > droping win32 support saves us from more
> > also if i had to choose between drping suport for a buggy gcc on a buggy os
> > vs. some senseless double memcpy() then i would instantly choose the first
> >
> > please do not suggest to add such terrible hacks for things which have
> > several clean soltions like droping win32 support, disabling SSE on win32, 
> > requireing gcc 4.2 and realignung the stack on win32, decoding data
> > interleaved, ...
> >   
> 
> I remeber adding one of those terrible hacks to the wma decoder. Should 
> it be reverted 

i searched for lars & wma but the 2 matches didnt look like what you
describe ...


> and a note that gcc 4.2 is required for win32 be added to 
> the homepage ?

this is not strictly true as uoti already said ...

its rather SSE && (gcc < 4.0 || gcc<4.2 && called_by_broken_code)
and called_by_broken_code is 1 currently but may change in future in
mingw/cygwin ...
also we need to add these gcc 4.2 attributes ...
and SSE could be reduced to SSE_using_the_stack if someone would go over
the code and add appropriate #ifdefs though iam not sure if adding alot
of ifdefs is a good idea ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070802/5095300a/attachment.pgp>