[Ffmpeg-cvslog] r6338 - in trunk: ffmpeg.c libavcodec/mpegvideo.c libavcodec/ratecontrol.c libavcodec/snow.c

Michael Niedermayer michaelni
Fri Sep 29 20:05:22 CEST 2006


Hi

On Fri, Sep 29, 2006 at 08:57:39PM +0300, Oded Shimon wrote:
> On Fri, Sep 29, 2006 at 07:54:29PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Thu, Sep 28, 2006 at 05:58:21PM +0100, M?ns Rullg?rd wrote:
> > > 
> > > Ismail Donmez said:
> > > > 28 Eyl 2006 Per 19:19 tarihinde, Panagiotis Issaris ??unlar?? yazm????t??:
> > > >> Hi,
> > > >>
> > > >> On wo, 2006-09-27 at 23:17 +0100, M?ns Rullg?rd wrote:
> > > >> >[...]
> > > >> >
> > > >> > >> Log:
> > > >> > >> Handle possible failure of ff_eval.
> > > >> > >
> > > >> > > That commit completely breaks mpeg encoding. Am I the only only
> > > >> > > actually encoding ? :>
> > > >> >
> > > >> > Should be fixed.
> > > >> >
> > > >> > To takis: please pay attention to compiler warnings when you make
> > > >> > changes.
> > > >>
> > > >> You are right. But, "make mpegvideo.o | grep warning|wc -l" returns 324 on
> > > >> my system, which makes it difficult to see the new ones in the pages of
> > > >> existing warnings...
> > > >
> > > > remove -Winline from configure and then you can see useful warnings.
> > > 
> > > Why was that flag added in the first place?
> > 
> > because i like to know when gcc decides to ignore me
> > furthermore if gcc ignores some inline then this isnt optimal, either
> > the inline should be changed to always_inline or the compiler parameters
> > should be changed or the inline should be removed
> 
> The problem is, sometimes removing inline creates a new warning :) static 
> function unused... (if you don't understand, think bitstream.h)

attribute((unused))

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-cvslog mailing list