[Ffmpeg-cvslog] r6356 - in trunk/libavcodec: asv1.c dv.c ffv1.c g726.c h263.c huffyuv.c i386/dsputil_mmx.c lcl.c mpegaudiodec.c mpegvideo.c msmpeg4.c png.c raw.c sonic.c svq1.c

[Rich Felker]

On Wed, Sep 27, 2006 at 11:38:28PM +0100, M?ns Rullg?rd wrote:
> >> >> Log:
> >> >> add some #ifdef CONFIG_ENCODERS/DECODERS
> >> >
> >> > iam against this change not only do i disslike havning these
> >> > #ifdefs around unused static functions (its gccs job to drop
> >> > them)
> >> 
> >> GCC prints ugly warnings without these.
> >
> > so its a gcc bug workaround?
> 
> One man's bug is another man's feature, I guess.  I personally don't
> consider it a bug that gcc warns about unused code.

I consider it a gcc bug. Whenever gcc is generating ugly warnings it
probably means you need to add some -Wno-* options, not (much uglier
than warnings!) hacks in the code itself! Flaming the gcc developers
is always fun too...

BTW it would be nice if _all_ of the #ifdefs (except in allcodecs.c)
could be eliminated by proper factoring of modules and such...

Rich