[Ffmpeg-cvslog] r6252 - trunk/libavcodec/utils.c

[Panagiotis Issaris]

Hi,

On do, 2006-09-14 at 19:30 +0200, Dominik 'Rathann' Mierzejewski wrote:
> [...]
> > --- trunk/libavcodec/utils.c	(original)
> > +++ trunk/libavcodec/utils.c	Thu Sep 14 16:02:32 2006
> > @@ -447,11 +447,11 @@
> >  #define E AV_OPT_FLAG_ENCODING_PARAM
> >  #define D AV_OPT_FLAG_DECODING_PARAM
> >  
> > -#define AV_CODEC_DEFAULT_BITRATE 800*1000
> > +#define AV_CODEC_DEFAULT_BITRATE 200*1000
> 
> Does it? The default has always been 800kbps.
No, the default which was actually being used, was set in ffmpeg.c,
and it was set to 200kbs from at least revision 862. Have a look at
line 108 of ffmpeg.c. The one specified in utils.c has never been
used.

The reason why I am changing it to 200kbs, is that I do not want
the regression tests to fail during a commit which enables AVOption
based parameters, replacing OptionDef based ones.

IMHO it will be better to have separate commit, changing the defaults
if necessary, which will make it obvious why the checksums have been
altered. If it would happen during the conversion from OptionDef to
AVOption, it would seem like a bug had been introduced.

With friendly regards,
Takis