[Ffmpeg-cvslog] r6213 - in trunk: Changelog MAINTAINERS doc/ffmpeg-doc.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/avcodec.h libavcodec/vp5.c libavcodec/vp56.c libavcodec/vp56.h libavcodec/vp56data.c libavcodec/vp56data.h libavcodec/vp5data.h libavcodec/vp6.c libavcodec/vp6data.h libavformat/flvdec.c libavformat/nsvdec.c libavformat/riff.c libavformat/swf.c

[Aurelien Jacobs]

On Mon, 11 Sep 2006 01:00:12 +0200
Aurelien Jacobs <aurel at gnuage.org> wrote:

> On Mon, 11 Sep 2006 00:52:53 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Mon, Sep 11, 2006 at 12:45:35AM +0200, Aurelien Jacobs wrote:
> > > On Sun, 10 Sep 2006 18:42:13 +0200
> > > Luca Barbato <lu_zero at gentoo.org> wrote:
> > > 
> > > > Aurelien Jacobs wrote:
> > > > > 
> > > > > What alignment is needed exactly ?
> > > > 
> > > > 16byte
> > > > 
> > > > > The only h264 function used is biweight_h264_pixels_tab[3].
> > > > 
> > > > 
> > > > Lets try to summarize
> > > > 
> > > > you use
> > > > 
> > > > put_pixels_tab[0][0]  ((line_size % 16) == 0)
> > > > put_pixels_tab[1][0]  unimplemented
> > > > put_no_rnd_pixels_l2[1] unimplemented
> > > > idct_put aligned input required
> > > > idct_add idem
> > > > biweight_h264_pixels_tab[3] unimplemented
> > > > 
> > > > which is the faulty one? ^^
> > > 
> > > As there is no altivec implementation of vp3 idct, it must be
> > > put_pixels_tab[0][0].
> > > Could you confirm it, testing with the following patch ?
> > 
> > Bingo, problem solved.
> 
> Ok, I will try to find a clean fix.

For now I can't find a fix to align memory, so here is a lame fix.
It replaces the dsp call by a pure C implementation. The code is
obviousily a bit slower (on pentium-m):

dsp version:
1706 dezicycles in vp_dsp, 2096933 runs, 219 skips
C version:
2001 dezicycles in vp_dsp, 2096934 runs, 218 skips

But the overall speed drop is less than 0.5%, so it's not so bad.

I will still think about it and if I can't find anything better
I will apply this tomorrow.

Can you confirm that it works ?

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vp_dsp.diff
Type: text/x-diff
Size: 992 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20060911/8edab4df/attachment.diff>