[Ffmpeg-cvslog] r6213 - in trunk: Changelog MAINTAINERS doc/ffmpeg-doc.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/avcodec.h libavcodec/vp5.c libavcodec/vp56.c libavcodec/vp56.h libavcodec/vp56data.c libavcodec/vp56data.h libavcodec/vp5data.h libavcodec/vp6.c libavcodec/vp6data.h libavformat/flvdec.c libavformat/nsvdec.c libavformat/riff.c libavformat/swf.c

[Aurelien Jacobs]

On Sun, 10 Sep 2006 14:39:21 +0200
Luca Barbato <lu_zero at gentoo.org> wrote:

> aurel wrote:
> [vp5/vp6 code]
> 
> You are feeding h264 dsp stuff with unaligned buffer in some part of mc,
> no I didn't track it yet the exact point.

What alignment is needed exactly ?
The only h264 function used is biweight_h264_pixels_tab[3].
The pointer which are feeded to it are :
 - tmp : the result of a realloc (should be safe except maybe with
         memalign_hack)
 - dst : granted to be 8 bytes aligned
 - src : not aligned at all (can point to any pixel in the reference
         picture)

It don't have an altivec version. Only a mmx2 version (which works
fine for me).

So is the alignment of src really needed ?
Is there any concrete problem right now ?

Aurel