[Ffmpeg-cvslog] r6213 - in trunk: Changelog MAINTAINERS doc/ffmpeg-doc.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/avcodec.h libavcodec/vp5.c libavcodec/vp56.c libavcodec/vp56.h libavcodec/vp56data.c libavcodec/vp56data.h libavcodec/vp5data.h libavcodec/vp6.c libavcodec/vp6data.h libavformat/flvdec.c libavformat/nsvdec.c libavformat/riff.c libavformat/swf.c

Luca Barbato lu_zero
Sat Sep 9 23:47:38 CEST 2006


Rich Felker wrote:
> On Sat, Sep 09, 2006 at 08:20:53PM +0200, Diego Biurrun wrote:
>> On Sat, Sep 09, 2006 at 07:19:42PM +0200, aurel wrote:
>>> --- (empty file)
>>> +++ trunk/libavcodec/vp5.c	Sat Sep  9 19:19:37 2006
>>> @@ -0,0 +1,289 @@
>>> +
>>> +static void vp5_parse_vector_adjustment(vp56_context_t *s, vp56_mv_t *vector)
>>> +{
>>> +
>>> +        if (!comp)
>>> +            vector->x = delta;
>>> +        else
>>> +            vector->y = delta;
>>> +    }
>>> +}
>> Please don't use vector as a name, I have compilation troubles on PPC:
> 
> Complain to GCC team or Apple or whoever made vector a keyword. It's
> NOT VALID. __vector is acceptable, vector is not. This problem will
> not go away by working around it.

vector is/should be a define not a keyword, same as pixel.
I'd rename it nonetheless.

(no, undef them isn't that sane)

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero





More information about the ffmpeg-cvslog mailing list