[Ffmpeg-cvslog] r6213 - in trunk: Changelog MAINTAINERS doc/ffmpeg-doc.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/avcodec.h libavcodec/vp5.c libavcodec/vp56.c libavcodec/vp56.h libavcodec/vp56data.c libavcodec/vp56data.h libavcodec/vp5data.h libavcodec/vp6.c libavcodec/vp6data.h libavformat/flvdec.c libavformat/nsvdec.c libavformat/riff.c libavformat/swf.c

[Diego Biurrun]

On Sat, Sep 09, 2006 at 07:19:42PM +0200, aurel wrote:
> --- (empty file)
> +++ trunk/libavcodec/vp5.c	Sat Sep  9 19:19:37 2006
> @@ -0,0 +1,289 @@
> +
> +static void vp5_parse_vector_adjustment(vp56_context_t *s, vp56_mv_t *vector)
> +{
> +
> +        if (!comp)
> +            vector->x = delta;
> +        else
> +            vector->y = delta;
> +    }
> +}

Please don't use vector as a name, I have compilation troubles on PPC:

vp5.c: In function 'vp5_parse_vector_adjustment':
vp5.c:87: error: parameter name omitted
vp5.c:104: error: expected expression before '__attribute__'
vp5.c:106: error: expected expression before '__attribute__'
make[1]: *** [vp5.o] Error 1

The same problem reappears in vp56.c and vp6.c.

> --- (empty file)
> +++ trunk/libavcodec/vp56.c	Sat Sep  9 19:19:37 2006
> @@ -0,0 +1,662 @@
> +
> +static int vp56_get_vectors_predictors(vp56_context_t *s, int row, int col,
> +                                       vp56_frame_t ref_frame)
> +{
> +    int nb_pred = 0;
> +    vp56_mv_t vector[2] = {{0,0}, {0,0}};
> +    int pos, offset;
> +    vp56_mv_t mvp;

C++ decls ..  There are some more, please don't ignore the warnings that
gcc spits out.

And before I forget, a general comment: :-)))))))))

Diego