[Ffmpeg-cvslog] r6551 - trunk/libavcodec/avcodec.h

Rich Felker dalias
Wed Oct 4 19:54:55 CEST 2006


On Wed, Oct 04, 2006 at 03:13:08PM +0200, bcoudurier wrote:
> Author: bcoudurier
> Date: Wed Oct  4 15:13:07 2006
> New Revision: 6551
> 
> Modified:
>    trunk/libavcodec/avcodec.h
> 
> Log:
> change extradata type to uint8_t *
> 
> Modified: trunk/libavcodec/avcodec.h
> ==============================================================================
> --- trunk/libavcodec/avcodec.h	(original)
> +++ trunk/libavcodec/avcodec.h	Wed Oct  4 15:13:07 2006
> @@ -741,7 +741,7 @@
>       * - encoding: set/allocated/freed by lavc.
>       * - decoding: set/allocated/freed by user.
>       */
> -    void *extradata;
> +    uint8_t *extradata;

Excellent change! Aside from avoiding the useless casts, it also
correctly conveys the semantics, that extradata is not a "pointer to
unknown type" but rather "pointer to sequence of bytes", i.e. that the
data it points to is serialized data that must be parsed by the codec
and not a C structure that you can use as-is (as some people used to
misinterpret it, IIRC).

Rich






More information about the ffmpeg-cvslog mailing list