[Ffmpeg-cvslog] Re: r7128 - trunk/libavformat/matroska.c

[Aurelien Jacobs]

On Mon, 20 Nov 2006 20:37:38 +0100
Steve Lhomme <steve.lhomme at free.fr> wrote:

> Alex Beregszaszi wrote:
> > Hi,
> > 
> >> @@ -2193,6 +2193,7 @@
> >>              enum CodecID codec_id = CODEC_ID_NONE;
> >>              uint8_t *extradata = NULL;
> >>              int extradata_size = 0;
> >> +            int extradata_offset = 0;
> >>              track = matroska->tracks[i];
> >>  
> >>              /* libavformat does not really support subtitles.
> >> @@ -2262,6 +2263,12 @@
> >>                  }
> >>              }
> >>  
> >> +            else if (codec_id == CODEC_ID_RV10 || codec_id ==
> >> CODEC_ID_RV20 || +                     codec_id == CODEC_ID_RV30 ||
> >> codec_id == CODEC_ID_RV40) { +                extradata_offset = 26;
> >> +                track->codec_priv_size -= extradata_offset;
> >> +            }
> > 
> > Lol? I dont want to flame, but why did the Matroska crew choose to
> > obfuscate every codec?

There are much more similar hacks still needed to support others codecs :(

> If you really wanted an answer you would post it to matroska-devel.
> 
> Anyway, I've had RealVideo decoding in DrFFMPEG working fine for about a 
> year without that hack. So I don't know why it has been added there but 
> it's probably not the right way to do it.

Really ? Do you have anything better to propose ?
Try to play RV20 in mkv with ffplay before and after this set of patch.

Aurel