[Ffmpeg-cvslog] r7050 - in trunk: configure libavutil/common.h

[Reimar Doeffinger]

Hello,
On Tue, Nov 14, 2006 at 01:30:05PM -0000, M?ns Rullg?rd wrote:
> *@reimardoeffinger.de said:
> >>
> >>-#ifndef EMULATE_INTTYPES
> >>+#ifdef HAVE_INTTYPES
> >> #   include <inttypes.h>
> >> #else
> >
> > This seems like a really bad idea to me, since this header is for use by external
> > programs AFAIK, which means that
> > 1) previous code would at worst fail because of missing inttypes.h, like this it
> > might use incorrect typedefs
> > 2) Such a change in a public header IMHO is an API change.
> 
> It is no more broken now than it used to be.  Conditional things like this simply
> do not belong in public headers at all.
> 
> Are there any systems still missing inttypes.h?  IIRC this was added for some
> old version of cygwin.  Modern cygwin versions have inttypes.h.

Actually, that exactly is the reason why it is more broken than before,
because before it defaulted to including inttypes.h
I  it might be best to just move it 40 lines up into
HAVE_AV_CONFIG_H (thus leaving it to any external user to make sure these are defined),
but it would still be an API change that should go with a version number bump.

Greetings,
Reimar Doeffinger