[Ffmpeg-cvslog] r6963 - trunk/libavformat/riff.c

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sun, Nov 12, 2006 at 06:33:59PM +0200, Oded Shimon wrote:
>> On Sun, Nov 12, 2006 at 05:31:49PM +0100, Diego Biurrun wrote:
>> > On Sun, Nov 12, 2006 at 05:22:11PM +0200, Oded Shimon wrote:
>> > > On Sat, Nov 11, 2006 at 03:08:40AM +0100, Michael Niedermayer wrote:
>> > > > 
>> > > > On Sat, Nov 11, 2006 at 01:22:08AM +0000, M?ns Rullg?rd wrote:
>> > > > > michael <subversion at mplayerhq.hu> writes:
>> > > > > 
>> > > > > > Log:
>> > > > > > libnut uses "MP3 " for mp3
>> > > > > >
>> > > > > > Modified: trunk/libavformat/riff.c
>> > > > > > ==============================================================================
>> > > > > > --- trunk/libavformat/riff.c	(original)
>> > > > > > +++ trunk/libavformat/riff.c	Sat Nov 11 01:29:49 2006
>> > > > > > @@ -200,6 +200,7 @@
>> > > > > >      // for NuppelVideo (nuv.c)
>> > > > > >      { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
>> > > > > >      { CODEC_ID_MP3, MKTAG('L', 'A', 'M', 'E') },
>> > > > > > +    { CODEC_ID_MP3, MKTAG('M', 'P', '3', ' ') },
>> > > > > 
>> > > > > Nooooo.  We were trying to get rid of those invalid bogus tags from
>> > > > > riff.c.  Don't add more of them.
>> > > > 
>> > > > nut per spec uses the avi-riff tags to identify codecs, libnut uses
>> > > > "MP3 " ...
>> > > > ask oded why
>> > > 
>> > > I actually don't know myself. Ask Rich, he told me to do it. :/ BTW, I use 
>> > > "mp3 " (no caps).
>> > 
>> > Fix libnut then?  And I agree that this is confusing.  Does NUT use the
>> > same identifiers as AVI, 0x55 then, or not?
>> 
>> It used to be 0x55 .
>
> .. and what does the spec say? ..

It says nothing at all, because the authors refuse to fully specify
the format.

-- 
M?ns Rullg?rd
mru at inprovide.com