[Ffmpeg-cvslog] CVS: ffmpeg/libavformat matroska.c,1.21,1.22

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Wed, Mar 22, 2006 at 07:11:09PM +0000, M?ns Rullg?rd wrote:
>> michael at mplayerhq.hu (Michael Niedermayer CVS) writes:
>> 
>> > +                av_reduce(&st->codec->sample_aspect_ratio.num,
>> > +                          &st->codec->sample_aspect_ratio.den,
>> > +                          st->codec->height * videotrack->display_width,
>> > +                          st->codec-> width * videotrack->display_height,
>> > +                          255);
>> 
>> Why do you set the limit at 255?  I don't have any videos that require
>> a higher limit, but I see no reason to restrict it either.
>
> h263 and mpeg4 use 8/8bits to store custom ratios so more would cause
> problems for them

Wouldn't it be better to have limited codecs do the truncation
themselves?  Demuxers shouldn't be imposing arbitrary limits.

-- 
M?ns Rullg?rd
mru at inprovide.com