[Ffmpeg-cvslog] CVS: ffmpeg/libavformat dv1394.c,1.19,1.20

[Luca Abeni]

Hi all,

On Wed, 2006-03-08 at 12:43 +0100, Diego Biurrun CVS wrote:
[...]
> diff -u -d -r1.19 -r1.20
> --- dv1394.c	12 Jan 2006 22:43:22 -0000	1.19
> +++ dv1394.c	8 Mar 2006 11:43:10 -0000	1.20
> @@ -173,7 +173,7 @@
>              return AVERROR_IO;
>          }
>  #ifdef DV1394_DEBUG
> -        fprintf(stderr, "DV1394: status\n"
> +        av_log(context, AV_LOG_ERROR, "DV1394: status\n"
>                  "\tactive_frame\t%d\n"
>                  "\tfirst_clear_frame\t%d\n"
>                  "\tn_clear_frames\t%d\n"
Just a little question: why an "av_log(context, AV_LOG_ERROR, ...)"
inside an "#ifdef DV1394_DEBUG"?
AV_LOG_ERROR seems to imply that the message is critical, but on the
other hand it can be missed if DV1394_DEBUG is not defined...

Maybe an "av_log(context, AV_LOG_DEBUG, ...)" (without #idef?) would be
more appropriate?

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Gioca con la DOG-MACHINE di Pedigree: vinci ogni giorno simpatici premi per il tuo cane. Vai subito!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=4876&d=8-3