[Ffmpeg-cvslog] r5505 - trunk/libavformat/utils.c

Michael Niedermayer michaelni
Wed Jun 21 13:23:20 CEST 2006


On Wed, Jun 21, 2006 at 11:11:41AM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer said:
> > Hi
> >
> > On Tue, Jun 20, 2006 at 09:46:09PM +0200, mru wrote:
> >> Author: mru
> >> Date: Tue Jun 20 21:46:09 2006
> >> New Revision: 5505
> >>
> >> Modified:
> >>    trunk/libavformat/utils.c
> >>
> >> Log:
> >> increase search limit in av_find_stream_info
> >
> > please specify in the commit message or a comment in the source why
> > the new value is needed, so that in case someone changes that code, he
> > can test that problematic videos still work
> What could the reason be other than some video requiring it?  This time
> it was an MPEG PS file, but that doesn't mean all MPEG PS files need this.

does that video also have an url?
increasing these limits arbitrarily means added delay for some cases at
startup, the limit should in case we cant find a better solution be
user specifyable

and to find a better solution knowing which files where problematic in
the first place is quite helpfull for testing

a better solution might be for example that we could stop searching when
we have 1 audio and 1 video stream and the container normally doesnt have
more streams or we could use different limits for file:// vs. over the
net / streaming stuff

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-cvslog mailing list