[Ffmpeg-cvslog] Re: r5468 - trunk/libavformat/mov.c

[Baptiste Coudurier]

Michael Niedermayer wrote:
> Hi
> 
> On Mon, Jun 12, 2006 at 03:09:20PM +0200, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Mon Jun 12 15:09:19 2006
>> New Revision: 5468
>>
>> Modified:
>>    trunk/libavformat/mov.c
>>
>> Log:
>> simplify, completely ignore streams not recognized, that fixes seeking for some files
> 
> iam strongly against ignoring unrecogized streams, a demuxer should present
> whats in the file to the user application, if this breaks seeking the bug
> is somewhere else
> 
> 
> [...]
> 

You would be more in favor of presenting those CODEC_TYPE_MOV_OTHER
streams ? Atm streams are not presented to libavformat but stays in the
demuxer private layer.

I see no point presenting a stream the demuxer cannot demux.

Now, situation is:
- either remove streams like I did.
- present them to libavformat, assigning CODEC_ID_DATA or CODEC_ID_NONE.

Do you prefer the latter ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312