[Ffmpeg-cvslog] r5740 - in trunk/libavutil: Makefile lls.c lls.h

[Michael Niedermayer]

Hi

On Fri, Jul 14, 2006 at 01:34:07PM -0400, Rich Felker wrote:
[...]
> > > Also I think this is inappropriate practice. There may be a reason
> 
> I should clarify I think. I didn't mean that using assert is
> inappropriate in itself, but rather that overriding the build
> process's definition of NDEBUG is inappropriate since NDEBUG signals
> that the person building does not want asserts.

i agree but theres a problem, some asserts are irrelevant
speedwise and some are in speed-critical parts, and there are some people
(me for example, and possibly other developers...) who want the rarely
executed asserts() to be enabled while the often executed ones should be
disabled in their build ... a global NDEBUG is not enough here

IIRC ive already at least suggested once that 2 av_asserts, one for
speedcritical and one for non-speedcritical parts should be added
yeah i shouldnt suggest but rather do the work myself i know ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is