[Ffmpeg-cvslog] r5592 - trunk/libavutil/md5.c

[Michael Niedermayer]

Hi

On Mon, Jul 03, 2006 at 11:16:14AM +0200, lu_zero wrote:
> Author: lu_zero
> Date: Mon Jul  3 11:16:13 2006
> New Revision: 5592
> 
> Modified:
>    trunk/libavutil/md5.c
> 
> Log:
> big endian fix
> 
> Modified: trunk/libavutil/md5.c
> ==============================================================================
> --- trunk/libavutil/md5.c	(original)
> +++ trunk/libavutil/md5.c	Mon Jul  3 11:16:13 2006
> @@ -69,7 +69,11 @@
>          }\
>          a = b + (( a << t ) | ( a >> (32 - t) ));
>  
> +#ifdef WORDS_BIGENDIAN
> +static void body(uint32_t ABCD[4], uint32_t X[16]){
> +#else
>  static void body(uint32_t ABCD[4], const uint32_t X[16]){
> +#endif

iam against this, either make it const or not but not different depending on
endianness

and md5.c is maintained, this is a development policy violation, you should
have sent a patch / have asked first on ffmpeg-dev, if then noone awnsers
then you can commit your patch but dont just change other developers code
at will

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is